Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat(test): Failure test case for mypyc dictionary subclass views #19076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
Loading
from

Conversation

BobTheBuidler
Copy link

@BobTheBuidler BobTheBuidler commented May 12, 2025

I've created a failing test case for a mypyc bug with dict views as seen here: https://github.com/BobTheBuidler/checksum_dict/actions/runs/14843222374/job/41670896987

I added some new (working) test cases:

  • dict
    • keys
    • values
    • items
  • dict subclass
    • keys
    • values
    • items

and the failure cases:

  • dict subclass with 2 bases
    • keys
    • values
    • items

@BobTheBuidler BobTheBuidler changed the title feat(test): test mypyc dict views feat(test): Failure test case for mypyc dictionary subclass views May 12, 2025
@BobTheBuidler
Copy link
Author

@JukkaL Would you happen to know what I need to change so the tests are able to find the DefaultDict object in the typing module? Or is there someone better to ask about this?

@BobTheBuidler
Copy link
Author

Fascinating, I've managed to make it work using a type: ignore comment, and now we have our successful (wut?) failure case!

@BobTheBuidler BobTheBuidler marked this pull request as ready for review May 14, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.