Bring back type annotation support of dunder methods in stub generator (fix #12717) #12828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Could you take a look at the failing tests? |
|
It basically what @shubz1998 already mentioned in comment #12524 (comment):
As an alternative we can also just re-use the
which seems to make sense. With this change, the tests should need no adaptation, and relevant dunder methods like |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JelleZijlstra
approved these changes
May 21, 2022
JukkaL
pushed a commit
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the Contributing Guidelines?
Yes.
Description
Fixes #12717 by making the "ignoring of dunder methods" more specific. As explained,
__members__is part of the official enum API and thus an essential type annotation to have. The complete removal of annotations of dunder methods in #12524 causes a big regression for pybind11 code bases involving lots of enums.Test Plan
I didn't had time to add a specific test case preventing fully reverting #12524, but this modification should keep its behavior while fixing #12717.