Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Invalid definition of __eq__ on dataclasses #8638

Copy link
Copy link
Closed
@tkukushkin

Description

@tkukushkin
Issue body actions

This code does not work. It defines __eq__ method like this:

def __eq__(self: T, other: T) -> bool: pass

But on this example

from dataclasses import dataclass

@dataclass
class A: pass

reveal_type(A.__eq__)

latest version of mypy outputs

test.py:6: note: Revealed type is 'def (builtins.object, builtins.object) -> builtins.bool'

And it is right, I think dataclasses shouldn't override __eq__ signature of base object type and we should remove this broken code completely.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.