Add zstd to build dependencies #1558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanFromIreland
commented
May 9, 2025
core-developers/experts.rst
Outdated
| @@ -258,6 +259,7 @@ zipapp pfmoore | ||
| zipfile alanmcintyre^, serhiy-storchaka, Yhg1s, gpshead | ||
| zipimport Yhg1s* | ||
| zlib Yhg1s, gpshead* | ||
| compression.zstd |
There was a problem hiding this comment.
Do we use this ordering or should it be under compression?
ned-deily
reviewed
May 10, 2025
There was a problem hiding this comment.
The macOS dependencies section also needs to be updated:
- $ brew install pkg-config openssl@3 xz gdbm tcl-tk mpdecimal
+ $ brew install pkg-config openssl@3 xz gdbm tcl-tk mpdecimal zstd
and:
+ $ sudo port install pkgconfig openssl xz gdbm tcl tk +quartz mpdecimal
- $ sudo port install pkgconfig openssl xz gdbm tk +quartz mpdecimal zstd
(The removal of tcl is deliberate; it's a dependency of the tk port and thus does not need to be specified.)
StanFromIreland
commented
May 10, 2025
core-developers/experts.rst
Outdated
Comment on lines
80
to
81
| compression | ||
| compression.zstd |
There was a problem hiding this comment.
cc @AA-Turner You have been active here, do you want to be added? I don't think Emma can be added as I believe it is limited to core.
hugovk
reviewed
May 10, 2025
ned-deily
reviewed
May 10, 2025
AA-Turner
approved these changes
May 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1557
馃摎 Documentation preview 馃摎: https://cpython-devguide--1558.org.readthedocs.build/getting-started/setup-building/