remove static state from suggestions

python · kumaraditya303 · Nov 30, 2022 · Nov 12, 2022 · Nov 13, 2022 · Nov 13, 2022
commit 1153e99fa8ae4793a19fe7fcffe9c28bf0552ffe
diff --git a/Python/suggestions.c b/Python/suggestions.c
@@ -43,7 +43,7 @@ levenshtein_distance(const char *a, size_t a_size,
                     const char *b, size_t b_size,
                     size_t max_cost)
 {
-    static size_t buffer[MAX_STRING_SIZE];
+    size_t buffer[MAX_STRING_SIZE] = {0};

    // Both strings are the same (by identity)
    if (a == b) {
@@ -238,7 +238,7 @@ get_suggestions_for_name_error(PyObject* name, PyFrameObject* frame)
        if (!self) {
            goto error;
        }
-        
+
        if (PyObject_HasAttr(self, name)) {
            Py_DECREF(dir);
            return PyUnicode_FromFormat("self.%S", name);
-Original file line number
+Diff line change
@@ -43,7 +43,7 @@ levenshtein_distance(const char *a, size_t a_size,
                          const char *b, size_t b_size,
                          size_t max_cost)
     {
-        static size_t buffer[MAX_STRING_SIZE];
                   kumaraditya303 marked this conversation as resolved.
              

          
            Show resolved
            Hide resolved
        

                
  
            
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.
+        size_t buffer[MAX_STRING_SIZE] = {0};
                   kumaraditya303 marked this conversation as resolved.
              

          
            Show resolved
            Hide resolved
        

                
  
            
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


  


    
    
      
  
    
    
              
          
              
                  kumaraditya303 marked this conversation as resolved.
              

          
            Show resolved
            Hide resolved
        

                
  
            
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.
         // Both strings are the same (by identity)
         if (a == b) {
@@ -238,7 +238,7 @@ get_suggestions_for_name_error(PyObject* name, PyFrameObject* frame)
             if (!self) {
                 goto error;
             }
             if (PyObject_HasAttr(self, name)) {
                 Py_DECREF(dir);
                 return PyUnicode_FromFormat("self.%S", name);
-          Expand Down