Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 #97896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 5, 2022
Merged

gh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 #97896

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
79505df
Port test cases to IsolatedAsyncioTestCase, part 2
arhadthedev Oct 5, 2022
a46c222
Remove self.loop.set_exception_handler
arhadthedev Oct 5, 2022
ee7e966
Another fix
arhadthedev Oct 5, 2022
bc21d76
Fix a misuse of async with
arhadthedev Oct 5, 2022
87e841c
Remove more asyncio.open_connection()
arhadthedev Oct 5, 2022
7b8caca
Return an assignment to data
arhadthedev Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove more asyncio.open_connection()
  • Loading branch information
@arhadthedev
arhadthedev authored Oct 5, 2022
commit 87e841c59a12625f5ba531f71b71a2bda195ff0a
12 changes: 4 additions & 8 deletions 12 Lib/test/test_asyncio/test_streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,8 +944,7 @@ def test_LimitOverrunError_pickleable(self):
class NewStreamTests2(unittest.IsolatedAsyncioTestCase):
async def test_wait_closed_on_close(self):
with test_utils.run_test_server() as httpd:
rd, wr = self.loop.run_until_complete(
asyncio.open_connection(*httpd.address))
rd, wr = await asyncio.open_connection(*httpd.address)

wr.write(b'GET / HTTP/1.0\r\n\r\n')
data = await rd.readline()
Expand All @@ -962,8 +961,7 @@ async def test_wait_closed_on_close_with_unread_data(self):
rd, wr = await asyncio.open_connection(*httpd.address)

wr.write(b'GET / HTTP/1.0\r\n\r\n')
f = rd.readline()
data = self.loop.run_until_complete(f)
data = await rd.readline()
self.assertEqual(data, b'HTTP/1.0 200 OK\r\n')
wr.close()
await wr.wait_closed()
Expand Down Expand Up @@ -1005,11 +1003,9 @@ async def test_eof_feed_when_closing_writer(self):
with test_utils.run_test_server() as httpd:
rd, wr = await asyncio.open_connection(*httpd.address)
wr.close()
f = wr.wait_closed()
self.loop.run_until_complete(f)
await wr.wait_closed()
self.assertTrue(rd.at_eof())
f = rd.read()
data = self.loop.run_until_complete(f)
data = await rd.read()
self.assertEqual(data, b'')


Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.