Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-95196: Disable incorrect pickling of the C implemented classmethod descriptors #96383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 5, 2022
Merged

gh-95196: Disable incorrect pickling of the C implemented classmethod descriptors #96383

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
abe2e5a
gh-95196: Disable incorrect pickling of the C implemented classmethod…
serhiy-storchaka Aug 29, 2022
d79301d
Fix debugging remnants.
serhiy-storchaka Aug 29, 2022
06880bb
Merge branch 'main' into c-classmethod-descriptor-reduce
serhiy-storchaka Oct 5, 2022
dadbf00
Add some comments.
serhiy-storchaka Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix debugging remnants.
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Aug 29, 2022
commit d79301df32808574d3ab914e85e4f0eb0cc403ee
3 changes: 1 addition & 2 deletions 3 Lib/test/pickletester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2814,8 +2814,7 @@ class Nested(str):
(Subclass.Nested("sweet").count, ("e",)),
(Subclass.Nested.count, (Subclass.Nested("sweet"), "e")),
)
#for proto in range(pickle.HIGHEST_PROTOCOL + 1):
for proto in [5]:
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
for method, args in c_methods:
with self.subTest(proto=proto, method=method):
unpickled = self.loads(self.dumps(method, proto))
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.