Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-93654: Add module docstring to pathlib #94611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2022

Conversation

kj7rrv
Copy link
Contributor

@kj7rrv kj7rrv commented Jul 6, 2022

Issue: gh-93654

Automerge-Triggered-By: GH:brettcannon

@kj7rrv
Copy link
Contributor Author

kj7rrv commented Jul 6, 2022

What is the correct way to mark up the name of a class in ReST?

@brettcannon
Copy link
Member

/cc @barneygale

What is the correct way to mark up the name of a class in ReST?

I assume you're referring to your news entry, and in that instance you don't mark up the class name.

@kj7rrv
Copy link
Contributor Author

kj7rrv commented Jul 6, 2022

@brettcannon 2acf6de should fix it.

Lib/pathlib.py Outdated Show resolved Hide resolved
kj7rrv and others added 2 commits July 6, 2022 18:26
Co-authored-by: Éric <merwok@netwok.org>
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@merwok merwok changed the title gh-93654: Add docstring to pathlib gh-93654: Add module docstring to pathlib Jul 7, 2022
@merwok
Copy link
Member

merwok commented Jul 7, 2022

✅ but I would like someone else to approve the text 🙂

Copy link
Contributor

@barneygale barneygale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.