Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-93243: Make smtpd private before porting its users #93246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Aug 6, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions 3 Doc/library/email.rst
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,3 @@ Legacy API:
Module :mod:`mailbox`
Tools for creating, reading, and managing collections of messages on disk
using a variety standard formats.

Module :mod:`smtpd`
SMTP server framework (primarily useful for testing)
267 changes: 0 additions & 267 deletions 267 Doc/library/smtpd.rst

This file was deleted.

1 change: 0 additions & 1 deletion 1 Doc/library/superseded.rst
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ backwards compatibility. They have been superseded by other modules.
optparse.rst
ossaudiodev.rst
pipes.rst
smtpd.rst
sndhdr.rst
spwd.rst
sunau.rst
Expand Down
11 changes: 11 additions & 0 deletions 11 Doc/whatsnew/3.12.rst
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,13 @@ Removed

(Contributed by Erlend E. Aasland in :gh:`92548`)

* :mod:`smtpd`, deprecated in Python 3.4.7 and 3.5.4, is now removed according
to :pep:`594` schedule. Use aiosmtpd_ PyPI module or any other
arhadthedev marked this conversation as resolved.
Show resolved Hide resolved
:keyword:`async`/:keyword:`await`-based server instead.
(Contributed by Oleg Iarygin in :gh:`93243`.)

.. _aiosmtpd: https://pypi.org/project/aiosmtpd/


Porting to Python 3.12
======================
Expand All @@ -140,6 +147,10 @@ Changes in the Python API
select from a larger range than ``randrange(10**25)``.
(Originally suggested by Serhiy Storchaka gh-86388.)

* Removed strictly synchronous smtpd module, deprecated in Python 3.4.7 and
arhadthedev marked this conversation as resolved.
Show resolved Hide resolved
3.5.4. A recommended replacement is the
:keyword:`async`/:keyword:`await`-based aiosmtpd_ PyPI module.


Build Changes
=============
Expand Down
File renamed without changes.
4 changes: 2 additions & 2 deletions 4 Lib/test/mock_socket.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"""Mock socket module used by the smtpd and smtplib tests.
"""Mock socket module used by smtplib tests.
arhadthedev marked this conversation as resolved.
Show resolved Hide resolved
"""

# imported for _GLOBAL_DEFAULT_TIMEOUT
Expand Down Expand Up @@ -33,7 +33,7 @@ def close(self):


class MockSocket:
"""Mock socket object used by smtpd and smtplib tests.
"""Mock socket object used by smtplib tests.
arhadthedev marked this conversation as resolved.
Show resolved Hide resolved
"""
def __init__(self, family=None):
global _reply_data
Expand Down
2 changes: 1 addition & 1 deletion 2 Lib/test/test_logging.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@


asyncore = warnings_helper.import_deprecated('asyncore')
smtpd = warnings_helper.import_deprecated('smtpd')
smtpd = warnings_helper.import_deprecated('_smtpd')


try:
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.