Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-91755: Document Py_IncRef and Py_DecRef as C function. #91805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 18, 2022

Conversation

CharlieZhao95
Copy link
Contributor

Document Py_IncRef and Py_DecRef as C function in Reference Counting docs.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 22, 2022
@CharlieZhao95 CharlieZhao95 marked this pull request as draft April 22, 2022 02:27
@CharlieZhao95 CharlieZhao95 marked this pull request as ready for review April 22, 2022 02:49
@kumaraditya303 kumaraditya303 requested a review from encukou May 2, 2022 15:08
@AlexWaygood
Copy link
Member

I'm way out of my depth on this one, so I'll pass on reviewing, sorry :)

@AlexWaygood AlexWaygood requested review from JelleZijlstra and removed request for AlexWaygood May 17, 2022 09:56
Doc/c-api/refcounting.rst Outdated Show resolved Hide resolved
Doc/c-api/refcounting.rst Outdated Show resolved Hide resolved
@JelleZijlstra JelleZijlstra added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels May 17, 2022
@erlend-aasland
Copy link
Contributor

erlend-aasland commented May 18, 2022

Resolves #91755

(apparently, autolinking only works from OP...)

erlend-aasland and others added 2 commits May 18, 2022 10:07
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@erlend-aasland erlend-aasland merged commit 58a3d28 into python:main May 18, 2022
@miss-islington
Copy link
Contributor

Thanks @CharlieZhao95 for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-92916 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed needs backport to 3.11 only security fixes needs backport to 3.10 only security fixes labels May 18, 2022
@bedevere-bot
Copy link

GH-92917 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2022
…onGH-91805)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 58a3d28)

Co-authored-by: Charlie Zhao <zhaoyu_hit@qq.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2022
…onGH-91805)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 58a3d28)

Co-authored-by: Charlie Zhao <zhaoyu_hit@qq.com>
miss-islington added a commit that referenced this pull request May 18, 2022
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 58a3d28)

Co-authored-by: Charlie Zhao <zhaoyu_hit@qq.com>
miss-islington added a commit that referenced this pull request May 18, 2022
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 58a3d28)

Co-authored-by: Charlie Zhao <zhaoyu_hit@qq.com>
@erlend-aasland
Copy link
Contributor

FTR, approved by Petr offline.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.