bpo-28810: Update lnotab_notes.txt#665
Merged
serhiy-storchaka merged 3 commits intopython:masterpython/cpython:masterfrom Mar 14, 2017
Merged
bpo-28810: Update lnotab_notes.txt#665serhiy-storchaka merged 3 commits intopython:masterpython/cpython:masterfrom
serhiy-storchaka merged 3 commits intopython:masterpython/cpython:masterfrom
Conversation
|
@ilevkivskyi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @avassalotti to be a potential reviewer. |
Objects/lnotab_notes.txt
Outdated
| lineno += line_incr | ||
|
|
||
| (In C, this is implemented by PyCode_Addr2Line().) In order for this to work, | ||
| (In C, this is implemented by PyCode_Addr2Line(). Note that before 3.6, only |
Member
There was a problem hiding this comment.
Use two spaces between sentences.
I think that the better place for this note is few lines above, when describe the range of line_incr.
Member
|
The line doesn't look correct (the maximal And while we are here please change "Python string" to "bytes object" (or "Python bytes object"). |
serhiy-storchaka
approved these changes
Mar 14, 2017
Member
|
Ah, and while we are here, please fix tabs used instead of spaces. |
vstinner
approved these changes
Mar 14, 2017
Member
Author
Fixed. I have found only three lines with tabs in this file. |
Mariatta
pushed a commit
to Mariatta/cpython
that referenced
this pull request
Mar 31, 2017
(cherry picked from commit 9135275)
Mariatta
added a commit
that referenced
this pull request
Mar 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@serhiy-storchaka @brettcannon Here is the separate PR for
lnotab_notes.txtthat I promised.This needs to be backported to 3.6.