bpo-33314: Fix rendering issues in the documentation for the os module #6525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doc/library/os.rst
Outdated
| @@ -1127,13 +1127,15 @@ or `the MSDN <https://msdn.microsoft.com/en-us/library/z0kc8e3z.aspx>`_ on Windo | ||
| .. versionadded:: 3.7 | ||
|
|
||
| .. data:: RWF_DSYNC (since Linux 4.7) |
There was a problem hiding this comment.
I would add the line
Availability: Linux (version 4.7).
after the description.
There was a problem hiding this comment.
Do you mean maintaining (since Linux 4.7) or eliminating that and adding Availability: Linux (version 4.7). at the end?
There was a problem hiding this comment.
Yes, eliminate it. Currently (since Linux 4.7) is rendered as a signature of the RWF_DSYNC callable.
There was a problem hiding this comment.
@serhiy-storchaka Done in b8eea4e
brettcannon
approved these changes
Apr 19, 2018
serhiy-storchaka
approved these changes
Apr 25, 2018
|
@serhiy-storchaka: Please replace |
|
Thanks @pablogsal for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-6597 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 25, 2018
serhiy-storchaka
pushed a commit
that referenced
this pull request
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue33314
Example of the problem:
https://docs.python.org/3.7/library/os.html#os.RWF_NOWAIT