[3.6] bpo-25720: Fix the method for checking pad state of curses WINDOW (GH-4164)#4212
Merged
serhiy-storchaka merged 1 commit intopython:3.6python/cpython:3.6from Nov 1, 2017
miss-islington:backport-8bc7d63-3.6miss-islington/cpython:backport-8bc7d63-3.6Copy head branch name to clipboard
Merged
[3.6] bpo-25720: Fix the method for checking pad state of curses WINDOW (GH-4164)#4212serhiy-storchaka merged 1 commit intopython:3.6python/cpython:3.6from miss-islington:backport-8bc7d63-3.6miss-islington/cpython:backport-8bc7d63-3.6Copy head branch name to clipboard
serhiy-storchaka merged 1 commit intopython:3.6python/cpython:3.6from
miss-islington:backport-8bc7d63-3.6miss-islington/cpython:backport-8bc7d63-3.6Copy head branch name to clipboard
Conversation
…thonGH-4164) Modify the code to use ncurses is_pad() instead of checking WINDOW _flags field. If your platform does not provide the is_pad(), the existing way that checks the field will be enabled. Note: This change does not drop support for platforms where do not have both WINDOW _flags field and is_pad(). (cherry picked from commit 8bc7d63)
Contributor
Author
|
@ma8ma and @serhiy-storchaka: Backport status check is done, and it's a success ✅ . |
Contributor
Author
|
Thanks, @serhiy-storchaka! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the code to use ncurses is_pad() instead of checking WINDOW
_flags field. If your platform does not provide the is_pad(), the
existing way that checks the field will be enabled.
Note: This change does not drop support for platforms where do not
have both WINDOW _flags field and is_pad().
(cherry picked from commit 8bc7d63)
https://bugs.python.org/issue25720