Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

bpo-47250: Fix refleak from object.__getstate__()#32403

Merged
corona10 merged 1 commit intopython:mainpython/cpython:mainfrom
corona10:bpo-47250corona10/cpython:bpo-47250Copy head branch name to clipboard
Apr 7, 2022
Merged

bpo-47250: Fix refleak from object.__getstate__()#32403
corona10 merged 1 commit intopython:mainpython/cpython:mainfrom
corona10:bpo-47250corona10/cpython:bpo-47250Copy head branch name to clipboard

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented Apr 7, 2022 •
edited by bedevere-bot
Loading

@corona10 @brandtbucher
bpo-47250: Fix refleak from object.__getstate__()
662c7cc 
Co-authored-by: Brandt Bucher <brandt@python.org>
@corona10 corona10 requested a review from markshannon as a code owner April 7, 2022 17:30
@corona10
Copy link
Member Author

corona10 commented Apr 7, 2022 •
edited
Loading 


$ ./python.exe -m test -R 3:3 test_descr -m test_issue24097
Raised RLIMIT_NOFILE: 256 -> 1024
0:00:00 load avg: 4.63 Run tests sequentially
0:00:00 load avg: 4.63 [1/1] test_descr
beginning 6 repetitions
123456
......

== Tests result: SUCCESS ==

1 test OK.

Total duration: 107 ms
Tests result: SUCCESS

brandtbucher
brandtbucher approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Do you wanna feed it to the buildbots, just in case?

@corona10 corona10 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 7, 2022
@bedevere-bot
Copy link

bedevere-bot commented Apr 7, 2022

🤖 New build scheduled with the buildbot fleet by @corona10 for commit 662c7cc 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 7, 2022
@corona10
Copy link
Member Author

corona10 commented Apr 7, 2022

Thanks. Do you wanna feed it to the buildbots, just in case?

Yeah, let's run the bots

@brandtbucher brandtbucher mentioned this pull request Apr 7, 2022
Merged
vstinner
vstinner approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@corona10 corona10 merged commit e2d78ba into python:main Apr 7, 2022
@corona10 corona10 deleted the bpo-47250 branch April 7, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@corona10 @bedevere-bot @vstinner @brandtbucher @the-knights-who-say-ni
Morty Proxy This is a proxified and sanitized view of the page, visit original site.