-
-
Notifications
You must be signed in to change notification settings - Fork 32k
bpo-47120: make POP_JUMP_IF_NONE/NOT_NONE relative #32359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The case of POP_JUMP_IF_TRUE/IF_FALSE is more complicated because of the COMPARE_OP specialisations. I suggest we do it separately (my current patch doesn't work unless I turn off specialization, debugging). |
Misc/NEWS.d/next/Core and Builtins/2022-04-06-22-50-31.bpo-47120.mbfHs5.rst
Outdated
Show resolved
Hide resolved
The |
Which means the forwards jumps can be made simpler
|
I fixed it now, it was the usual +-1 business. I'll make a separate PR for that, it will be easier to review that way. We can merge magic number later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This will be merged as part of #32400 |
https://bugs.python.org/issue47120