Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove trailing spaces #31695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

serhiy-storchaka
Copy link
Member

No description provided.

@@ -18,7 +18,7 @@
#endif

#include "Python.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the changes in this file accidental?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a generated file. After regenerating all I got this.

@JelleZijlstra
Copy link
Member

Thanks for fixing this!

Is there a place we could check for trailing spaces in CI? I'd rather not have to periodically check for this and make another similar PR.

@serhiy-storchaka
Copy link
Member Author

AFAIK there were scripts and Makefile targets, but they were disabled.

@serhiy-storchaka serhiy-storchaka merged commit 6927632 into python:main Mar 5, 2022
@serhiy-storchaka serhiy-storchaka deleted the trailing-spaces branch March 5, 2022 15:47
@erlend-aasland
Copy link
Contributor

Thanks for fixing this!

Is there a place we could check for trailing spaces in CI? I'd rather not have to periodically check for this and make another similar PR.

+1 from me. Let's open an issue over at python/core-workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.