Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

bpo-46543: add sys._getcaller#30950

Closed
JelleZijlstra wants to merge 9 commits intopython:mainpython/cpython:mainfrom
JelleZijlstra:sys_getcallJelleZijlstra/cpython:sys_getcallCopy head branch name to clipboard
Closed

bpo-46543: add sys._getcaller#30950
JelleZijlstra wants to merge 9 commits intopython:mainpython/cpython:mainfrom
JelleZijlstra:sys_getcallJelleZijlstra/cpython:sys_getcallCopy head branch name to clipboard

Conversation

@JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Jan 27, 2022 •
edited by bedevere-bot
Loading

@JelleZijlstra JelleZijlstra marked this pull request as draft January 27, 2022 04:20
markshannon
markshannon reviewed Feb 7, 2022
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks sound. A couple of minor issues.

Doc/library/sys.rst Outdated Show resolved Hide resolved
Python/sysmodule.c Outdated Show resolved Hide resolved
@markshannon
Copy link
Member

markshannon commented Feb 7, 2022

I don't like the name _getfunc, as explained in faster-cpython/ideas#238 (comment)

@JelleZijlstra
Copy link
Member Author

JelleZijlstra commented Feb 8, 2022

Thanks, I'll go back to _getcaller based on the discussion on faster-cpython.

@gvanrossum gvanrossum changed the title bpo-46543: add sys._getfunc bpo-46543: add sys._getcaller Feb 8, 2022
@JelleZijlstra
Copy link
Member Author

JelleZijlstra commented Apr 6, 2022

@markshannon would you still like this to make it into 3.11?

@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented Apr 6, 2022

@JelleZijlstra I don't know about Mark, but personally I'd like to see it in 3.11. Would my review be enough? (I've held off reviewing since it's draft).

@markshannon
Copy link
Member

markshannon commented Apr 6, 2022

Unfortunately there are a few problems with this, which stem from function.__code__ being mutable.

  1. Promoting the use of sys._getcaller instead of sys._getframe is flawed when you want the code object, as the caller function's __code__ attribute may have changed so that sys._getcaller(1).__code__ != sys.getframe(1).f_code which would be surprising. Changing the __code__ attribute of a function is a weird thing to do, so this might be OK.
  2. As internal structs cease to be part of the C-API, we may be able to implement Speed up frame handling in Python-to-Python calls. faster-cpython/ideas#111 which would mean that a reference to the caller function would no longer be available.
  3. In terms of Python semantics, a frame is defined by the (code, globals, builtins, locals) quad, not by the function from which it originally derived. The API should probably reflect that.

This was my idea originally, sorry for not spotting these flaws earlier.

@gvanrossum
Copy link
Member

gvanrossum commented Apr 6, 2022

Then should we just close this?

@rhettinger rhettinger removed their request for review May 3, 2022 06:19
@JelleZijlstra JelleZijlstra mentioned this pull request May 18, 2022
Closed
@JelleZijlstra JelleZijlstra mentioned this pull request Nov 15, 2022
Closed
@markshannon markshannon mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon left review comments

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood will be requested when the pull request is marked ready for review AlexWaygood is a code owner

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger will be requested when the pull request is marked ready for review rhettinger is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently will be requested when the pull request is marked ready for review ericsnowcurrently is a code owner

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JelleZijlstra @markshannon @Fidget-Spinner @gvanrossum @the-knights-who-say-ni @bedevere-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.