bpo-30570: Use Py_EnterRecursiveCall() in issubclass()#29048
Merged
gpshead merged 3 commits intopython:mainpython/cpython:mainfrom Oct 22, 2021
sweeneyde:issubclass_recursionsweeneyde/cpython:issubclass_recursionCopy head branch name to clipboard
Merged
bpo-30570: Use Py_EnterRecursiveCall() in issubclass()#29048gpshead merged 3 commits intopython:mainpython/cpython:mainfrom sweeneyde:issubclass_recursionsweeneyde/cpython:issubclass_recursionCopy head branch name to clipboard
gpshead merged 3 commits intopython:mainpython/cpython:mainfrom
sweeneyde:issubclass_recursionsweeneyde/cpython:issubclass_recursionCopy head branch name to clipboard
Conversation
gpshead
approved these changes
Oct 22, 2021
Member
gpshead
left a comment
There was a problem hiding this comment.
I added another test case (the specific example from the bug). Yours likely already covers it, just wanted it for pedantic reasons. I like this. Much nicer than mine. I was unaware of our new EnterRecursiveCall API pair. perfect! :)
Contributor
|
Thanks @sweeneyde for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 22, 2021
* Use Py_EnterRecursiveCall() in issubclass() Reviewed-by: Gregory P. Smith <greg@krypto.org> [Google] (cherry picked from commit 423fa1c) Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>
|
GH-29175 is a backport of this pull request to the 3.10 branch. |
Contributor
|
Thanks @sweeneyde for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
GH-29178 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 22, 2021
* Use Py_EnterRecursiveCall() in issubclass() Reviewed-by: Gregory P. Smith <greg@krypto.org> [Google] (cherry picked from commit 423fa1c) Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to GH-29017. This shouldn't affect performance too much because the recursion checks only occur once for each time a length>=2
__bases__tuple is found (i.e. for multiple inheritance). Note that if we get stuck in thewhile (1) {...}loop, as long as the pathological__bases__implementation is in Python, we can still interrupt with a KeyboardInterrupt.https://bugs.python.org/issue30570