bpo-30778: Skip test_bsddb3 on Windows XP#2877
Merged
vstinner merged 2 commits intopython:2.7python/cpython:2.7from Jul 26, 2017
vstinner:test_bsddb3_xpCopy head branch name to clipboard
Merged
bpo-30778: Skip test_bsddb3 on Windows XP#2877vstinner merged 2 commits intopython:2.7python/cpython:2.7from vstinner:test_bsddb3_xpCopy head branch name to clipboard
vstinner merged 2 commits intopython:2.7python/cpython:2.7from
vstinner:test_bsddb3_xpCopy head branch name to clipboard
Conversation
Member
Author
|
PR closed then reopened to retry AppVeyor. Previously, AppVeyor failed with: "continuous-integration/appveyor/pr — AppVeyor was unable to build non-mergeable pull request". |
zware
reviewed
Jul 26, 2017
Lib/test/test_bsddb3.py
Outdated
| sys.argv.remove('silent') | ||
|
|
||
| # bpo-30778: test_bsddb3 crashs randomly on Windows XP | ||
| if hasattr(sys, 'getwindowsversion') and sys.getwindowsversion()[:2] <= (6, 0): |
Member
There was a problem hiding this comment.
6.0 was Vista which we don't want to skip, so < rather than <=.
Member
Author
There was a problem hiding this comment.
Oops, I know that, it's a mistake. It's now fixed.
zware
approved these changes
Jul 26, 2017
Member
zware
left a comment
There was a problem hiding this comment.
We could play code golf to get it down to (or beyond) if getattr(sys, 'getwindowsversion', lambda: (9,))()[:1] < (6,):, but this is fine as is :)
Member
Author
Nice one, but I prefer my syntax ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue30778