Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

bpo-42972: Fully implement GC protocol for functools keywrapper and partial types #26363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 28, 2021
+37 −22
Merged

bpo-42972: Fully implement GC protocol for functools keywrapper and partial types #26363

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8ef6e98
bpo-42972: Fully implement GC protocol for functools types
May 25, 2021
6d7cdaf
Address review
May 26, 2021
a15b49f
Address review: visit node type for each strong ref
May 27, 2021
0c8df1f
Address review: visit members in correct order
May 27, 2021
f9ac4c5
Address review: revert Py_CLEAR change in lru_list_elem_dealloc
May 27, 2021
fc39917
Revert LRU cache element optimisation
May 27, 2021
07f2182
Address review: revert redundant slot removal
May 27, 2021
0861788
Address review: use tp_free
May 27, 2021
7c2f750
Revert lru list elem clear fn
May 27, 2021
6313247
Revert "Revert LRU cache element optimisation"
May 28, 2021
1539195
Restore lru_cache_tp_traverse
May 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review: revert Py_CLEAR change in lru_list_elem_dealloc
  • Loading branch information
Erlend E. Aasland committed May 27, 2021
commit f9ac4c5cbae43fa69299c64af2c4c11eec2d457e
4 changes: 2 additions & 2 deletions 4 Modules/_functoolsmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,8 +766,8 @@ static void
lru_list_elem_dealloc(lru_list_elem *link)
{
PyTypeObject *tp = Py_TYPE(link);
Py_CLEAR(link->key);
Py_CLEAR(link->result);
Py_XDECREF(link->key);
Py_XDECREF(link->result);
tp->tp_free(link);
erlend-aasland marked this conversation as resolved.
Show resolved Hide resolved
Py_DECREF(tp);
}
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.