Address review: fix ref.leak

python · erlend-aasland · Feb 6, 2021 · Feb 8, 2021 · Feb 8, 2021 · Feb 8, 2021
commit 19df6f9bf89800ec0fadc3e1136964707de2eb6e
diff --git a/Modules/_zoneinfo.c b/Modules/_zoneinfo.c
@@ -2670,10 +2670,10 @@ zoneinfomodule_exec(PyObject *m)
    }

    int rc = PyModule_AddObjectRef(m, "ZoneInfo", (PyObject *)PyZoneInfo_ZoneInfoType);
+    Py_DECREF(PyZoneInfo_ZoneInfoType);
    if (rc < 0) {
        goto error;
    }
-    Py_DECREF(PyZoneInfo_ZoneInfoType);

    /* Populate imports */
    PyObject *_tzpath_module = PyImport_ImportModule("zoneinfo._tzpath");