Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

bpo-42487: don't call __getitem__ of underlying maps in ChainMap.__iter__ #23534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 30, 2020
Merged

bpo-42487: don't call __getitem__ of underlying maps in ChainMap.__iter__ #23534

merged 3 commits into from
Nov 30, 2020

Conversation

ap--
Copy link
Contributor

@ap-- ap-- commented Nov 28, 2020 •
edited by bedevere-bot
Loading

@ap-- ap-- requested a review from rhettinger as a code owner November 28, 2020 01:00
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@ap--

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@rhettinger rhettinger self-assigned this Nov 28, 2020
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

rhettinger
rhettinger requested changes Nov 28, 2020
View reviewed changes
Copy link
Contributor

@rhettinger rhettinger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests and a blurb entry for Misc/NEWS. Also, please get the CLA signed.

@ap--
Copy link
Contributor Author

ap-- commented Nov 28, 2020 •
edited
Loading

Hi @rhettinger,
I added a test and the news blurb and signed the CLA (though it states on bpo it may take up to a few days to register...)

Thanks for the quick review and feedback :)

Cheers,
Andreas

serhiy-storchaka
serhiy-storchaka approved these changes Nov 28, 2020
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rhettinger rhettinger added the needs backport to 3.9 only security fixes label Nov 28, 2020
@rhettinger rhettinger merged commit 0be9ce3 into python:master Nov 30, 2020
@miss-islington
Copy link
Contributor

Thanks @ap-- for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-23569 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 30, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 30, 2020
@ap-- @miss-islington
bpo-42487: don't call __getitem__ of underlying maps in ChainMap.__it…
3df7f26 
…er__ (pythonGH-23534)

(cherry picked from commit 0be9ce3)

Co-authored-by: Andreas Poehlmann <andreas@poehlmann.io>
rhettinger pushed a commit that referenced this pull request Nov 30, 2020
@miss-islington
bpo-42487: don't call __getitem__ of underlying maps in ChainMap.__it…
cf22aa3 
…er__ (GH-23534) (GH-23569)
@ap-- ap-- deleted the chainmap-iter branch November 30, 2020 17:18
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@ap-- @adorilson
bpo-42487: don't call __getitem__ of underlying maps in ChainMap.__it…
b18ade5 
…er__ (pythonGH-23534)
@Alexamk Alexamk mentioned this pull request Jun 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger rhettinger approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

@rhettinger rhettinger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ap-- @the-knights-who-say-ni @bedevere-bot @miss-islington @rhettinger @serhiy-storchaka
Morty Proxy This is a proxified and sanitized view of the page, visit original site.