Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.9] bpo-28002: Roundtrip f-strings with ast.unparse better (GH-19612) #23430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 20, 2020

By attempting to avoid backslashes in f-string expressions.
We also now proactively raise errors for some backslashes we can't
avoid while unparsing FormattedValues

Co-authored-by: hauntsaninja <>
Co-authored-by: Shantanu hauntsaninja@users.noreply.github.com
Co-authored-by: Batuhan Taskaya isidentical@gmail.com
(cherry picked from commit a993e90)

Co-authored-by: Shantanu 12621235+hauntsaninja@users.noreply.github.com

https://bugs.python.org/issue28002

Automerge-Triggered-By: GH:isidentical

By attempting to avoid backslashes in f-string expressions.
We also now proactively raise errors for some backslashes we can't
avoid while unparsing FormattedValues

Co-authored-by: hauntsaninja <>
Co-authored-by: Shantanu <hauntsaninja@users.noreply.github.com>
Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
(cherry picked from commit a993e90)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@hauntsaninja
Copy link
Contributor

@isidentical Thanks for all the reviews and helping see this change through! :-)

There seems to be some issue with automerge on backports, so I think you'll need to manually merge; e.g. #22069 (comment)

@isidentical isidentical merged commit 3763cc1 into python:3.9 Nov 20, 2020
@miss-islington miss-islington deleted the backport-a993e90-3.9 branch November 20, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.