[3.6] bpo-35560: Remove assertion from format(float, "n") (GH-11288) #23231
Conversation
Fix an assertion error in format() in debug build for floating point formatting with "n" format, zero padding and small width. Release build is not impacted. Patch by Karthikeyan Singaravelan. (cherry picked from commit 3f7983a) Co-authored-by: Xtreak <tir.karthi@gmail.com>
|
@tirkarthi and @vstinner: Status check is done, and it's a success ✅ . |
|
@tirkarthi and @vstinner: Status check is done, and it's a success ✅ . |
1 similar comment
|
@tirkarthi and @vstinner: Status check is done, and it's a success ✅ . |
|
This fix of a bug introduced in 3.6 by fc4a44b#diff-34c966e7876d6f8bf801dd51896327e4f68bba02cddb95fbf3963f0b2e39c38a who's fix was never backported to 3.6. Something as simple as We run interpreters with assertions enabled during normal development. This causes perfectly valid Python code to crash the interpreter. Whether this is merged into 3.6 or not isn't up to me, but it does fix a assertion-enabled build bug that was introduced in 3.6.8. I'm creating the PR for reference and patching our own tree as appropriate. |
|
@tirkarthi and @vstinner: Status check is done, and it's a success ✅ . |
|
Sorry, I can't merge this PR. Reason: |
Fix an assertion error in format() in debug build for floating point
formatting with "n" format, zero padding and small width. Release build is
not impacted. Patch by Karthikeyan Singaravelan.
(cherry picked from commit 3f7983a)
Co-authored-by: Xtreak tir.karthi@gmail.com
https://bugs.python.org/issue35560