[3.8] bpo-42143: Ensure PyFunction_NewWithQualName() can't fail after creating the func object (GH-22953)#23022
Merged
miss-islington merged 1 commit intopython:3.8python/cpython:3.8from Oct 29, 2020
miss-islington:backport-3505261-3.8miss-islington/cpython:backport-3505261-3.8Copy head branch name to clipboard
Merged
[3.8] bpo-42143: Ensure PyFunction_NewWithQualName() can't fail after creating the func object (GH-22953)#23022miss-islington merged 1 commit intopython:3.8python/cpython:3.8from miss-islington:backport-3505261-3.8miss-islington/cpython:backport-3505261-3.8Copy head branch name to clipboard
miss-islington merged 1 commit intopython:3.8python/cpython:3.8from
miss-islington:backport-3505261-3.8miss-islington/cpython:backport-3505261-3.8Copy head branch name to clipboard
Conversation
…ing the func object (pythonGH-22953) func_dealloc() does not handle partially-created objects. Best not to give it any. (cherry picked from commit 3505261) Co-authored-by: Yonatan Goldschmidt <yon.goldschmidt@gmail.com>
serhiy-storchaka
approved these changes
Oct 29, 2020
Contributor
Author
|
@Jongy and @serhiy-storchaka: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@Jongy and @serhiy-storchaka: Status check is done, and it's a failure ❌ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
func_dealloc() does not handle partially-created objects. Best not to give it any.
(cherry picked from commit 3505261)
Co-authored-by: Yonatan Goldschmidt yon.goldschmidt@gmail.com
https://bugs.python.org/issue42143