Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.9] bpo-41659: Disallow curly brace directly after primary (GH-22996)#23006

Merged
lysnikolaou merged 1 commit intopython:3.9python/cpython:3.9from
lysnikolaou:backport-15acc4e-3.9lysnikolaou/cpython:backport-15acc4e-3.9Copy head branch name to clipboard
Oct 27, 2020
Merged

[3.9] bpo-41659: Disallow curly brace directly after primary (GH-22996)#23006
lysnikolaou merged 1 commit intopython:3.9python/cpython:3.9from
lysnikolaou:backport-15acc4e-3.9lysnikolaou/cpython:backport-15acc4e-3.9Copy head branch name to clipboard

Conversation

@lysnikolaou
Copy link
Member

@lysnikolaou lysnikolaou commented Oct 27, 2020

(cherry picked from commit 15acc4e)

https://bugs.python.org/issue41659

@lysnikolaou
Copy link
Member Author

I opened this PR without having made up my mind if we really should merge it or not. Having a left-recursive rule, that's called so frequently, open with an invalid alternative seems like it will have some performance implications. Should we maybe revisit backporting #22111 to 3.9 before merging this one?

CC @pablogsal @gvanrossum

@pablogsal
Copy link
Member

I opened this PR without having made up my mind if we really should merge it or not. Having a left-recursive rule, that's called so frequently, open with an invalid alternative seems like it will have some performance implications. Should we maybe revisit backporting #22111 to 3.9 before merging this one?

CC @pablogsal @gvanrossum

I would say that is wise to have an idea of the impact of this before doing anything, definitely.

@lysnikolaou
Copy link
Member Author

The stdlib benchmark went from 7.530s (mean from running it 4 times) in the 3.9 branch to 7.546s here.

@bedevere-bot
Copy link

@lysnikolaou: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.