Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[2.7] bpo-30500: urllib: Simplify splithost by calling into urlparse. (#1849)#2294

Merged
vstinner merged 1 commit intopython:2.7python/cpython:2.7from
vstinner:splithost27Copy head branch name to clipboard
Jun 20, 2017
Merged

[2.7] bpo-30500: urllib: Simplify splithost by calling into urlparse. (#1849)#2294
vstinner merged 1 commit intopython:2.7python/cpython:2.7from
vstinner:splithost27Copy head branch name to clipboard

Conversation

@vstinner
Copy link
Member

The current regex based splitting produces a wrong result. For example::

http://abc#@def

Web browsers parse that URL as http://abc/#@def, that is, the host
is abc, the path is /, and the fragment is #@def.
(cherry picked from commit 90e01e5)

The current regex based splitting produces a wrong result. For example::

  http://abc#@def

Web browsers parse that URL as ``http://abc/#@def``, that is, the host
is ``abc``, the path is ``/``, and the fragment is ``#@def``.
(cherry picked from commit 90e01e5)
@vstinner vstinner changed the title [2.7] urllib: Simplify splithost by calling into urlparse. (#1849) [2.7] bpo-30500: urllib: Simplify splithost by calling into urlparse. (#1849) Jun 20, 2017
@vstinner vstinner merged commit d4324ba into python:2.7 Jun 20, 2017
@vstinner vstinner deleted the splithost27 branch June 20, 2017 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-security A security issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.