Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-30604: clean up co_extra support #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 21, 2017
Merged

bpo-30604: clean up co_extra support #2144

merged 4 commits into from
Jun 21, 2017

Conversation

DinoV
Copy link
Contributor

@DinoV DinoV commented Jun 13, 2017

bpo-30604: port fix from 3.6 dropping binary compatibility tweaks

@mention-bot
Copy link

@DinoV, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mhammond, @benjaminp and @serhiy-storchaka to be potential reviewers.

@brettcannon brettcannon changed the title bpo-30604: port fix from 3.6 dropping binary compatibility tweaks bpo-30604: clean up co_extra support Jun 13, 2017
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the NEWS entry, but otherwise LGTM.

@@ -416,11 +416,11 @@ static void
code_dealloc(PyCodeObject *co)
{
if (co->co_extra != NULL) {
PyThreadState *tstate = PyThreadState_Get();
PyInterpreterState *interp= PyThreadState_Get()->interp;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: space before =

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, I figured I can fix this myself :)

@brettcannon brettcannon reopened this Jun 21, 2017
@1st1 1st1 merged commit f3cffd2 into python:master Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.