Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-32604: Disable failing tests #20777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2020

Conversation

nanjekyejoannah
Copy link
Contributor

@nanjekyejoannah nanjekyejoannah commented Jun 10, 2020

I decided to skip the tests in question until I get time to fix the races.

Requesting a second eye @pablogsal and @vstinner if this makes the bots green.

https://bugs.python.org/issue32604

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll see if we can track down the problem by the end of the week and get those tests re-enabled.

@vstinner
Copy link
Member

vstinner commented Jun 17, 2020

The PR title is very misleading: "bpo-32604: PEP 554 implementation: add interpreters module #20777".

@nanjekyejoannah nanjekyejoannah changed the title bpo-32604: PEP 554 implementation: add interpreters module bpo-32604: Disable failing tests Jun 17, 2020
@nanjekyejoannah nanjekyejoannah merged commit 6f79838 into python:master Jun 21, 2020
@nanjekyejoannah
Copy link
Contributor Author

Merging until we get a fix @ericsnowcurrently

fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
Co-authored-by: nanjekyejoannah <joannah.nanjekye@ibm.com>
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
Co-authored-by: nanjekyejoannah <joannah.nanjekye@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.