Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

bpo-40684: Fix make install for platlibdir=lib64#20736

Merged
vstinner merged 1 commit intopython:masterpython/cpython:masterfrom
vstinner:install_platlibdirCopy head branch name to clipboard
Jun 9, 2020
Merged

bpo-40684: Fix make install for platlibdir=lib64#20736
vstinner merged 1 commit intopython:masterpython/cpython:masterfrom
vstinner:install_platlibdirCopy head branch name to clipboard

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jun 8, 2020 •
edited
Loading

"make install" now uses the PLATLIBDIR variable for the destination
lib-dynload/ directory when ./configure --with-platlibdir is used.

Update --with-platlibdir comment in configure.

https://bugs.python.org/issue40684

@vstinner
Copy link
Member Author

vstinner commented Jun 8, 2020

Currently, --libdir=/usr/lib64 updates BINLIBDEST and DESTSHARED.

With this change, BINLIBDEST and DESTSHARED no longer depend on LIBDIR but always use $exec_prefix/$PLATLIBDIR/ path.

@hroncok @mcepl @ned-deily @zware: Would you mind to review this change? I'm not comfortable with changing the build system :-/

See https://bugs.python.org/issue40684 for the context and the bug.

@vstinner
Copy link
Member Author

vstinner commented Jun 8, 2020

To reduce the risk of regression, one option would be to continue to use BINLIBDEST= $(LIBDIR)/python$(VERSION) by default, but use BINLIBDEST= ${exec_prefix}/${PLATLIBDIR}/python$(VERSION) with --with-platlibdir= option is used.

@vstinner
bpo-40684: Fix make install for platlibdir=lib64
71a3a57 
"make install" now uses the PLATLIBDIR variable for the destination
lib-dynload/ directory when ./configure --with-platlibdir is used.

Update --with-platlibdir comment in configure.
@vstinner
Copy link
Member Author

vstinner commented Jun 9, 2020

To reduce the risk of regression, one option would be to continue to use BINLIBDEST= $(LIBDIR)/python$(VERSION) by default, but use BINLIBDEST= ${exec_prefix}/${PLATLIBDIR}/python$(VERSION) with --with-platlibdir= option is used.

Done. This PR has no more effect by default. Now it only changes BINLIBDEST when --with-platlibdir is used.

@mcepl
Copy link
Contributor

mcepl commented Jun 9, 2020

+1 from me

@vstinner vstinner merged commit 51ae31e into python:master Jun 9, 2020
@vstinner vstinner deleted the install_platlibdir branch June 9, 2020 13:33
@miss-islington
Copy link
Contributor

miss-islington commented Jun 9, 2020

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jun 9, 2020

GH-20761 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Jun 9, 2020
@miss-islington @vstinner
bpo-40684: Fix make install for platlibdir=lib64 (GH-20736)
6cb24a0 
"make install" now uses the PLATLIBDIR variable for the destination
lib-dynload/ directory when ./configure --with-platlibdir is used.

Update --with-platlibdir comment in configure.
(cherry picked from commit 51ae31e)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @mcepl @miss-islington @bedevere-bot @the-knights-who-say-ni
Morty Proxy This is a proxified and sanitized view of the page, visit original site.