Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.9] bpo-1294959: Try to clarify the meaning of platlibdir (GH-20332)#20497

Merged
miss-islington merged 1 commit intopython:3.9python/cpython:3.9from
miss-islington:backport-242d956-3.9miss-islington/cpython:backport-242d956-3.9Copy head branch name to clipboard
May 28, 2020
Merged

[3.9] bpo-1294959: Try to clarify the meaning of platlibdir (GH-20332)#20497
miss-islington merged 1 commit intopython:3.9python/cpython:3.9from
miss-islington:backport-242d956-3.9miss-islington/cpython:backport-242d956-3.9Copy head branch name to clipboard

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 28, 2020

Try to make the meaning of platlibdir clear. The previous wording could
be misinterpreted to suggest that it will be used to find all shared
libraries on the system, and not just Python extensions. Furthermore,
it was unclear whether it affects third-party (site-packages) extensions
or not. The new wording tries to make its dual purpose clear,
and provide the additional example of extensions in site-packages.
(cherry picked from commit 242d956)

Co-authored-by: Michał Górny mgorny@gentoo.org

https://bugs.python.org/issue1294959

Try to make the meaning of platlibdir clear.  The previous wording could
be misinterpreted to suggest that it will be used to find all shared
libraries on the system, and not just Python extensions.  Furthermore,
it was unclear whether it affects third-party (site-packages) extensions
or not.  The new wording tries to make its dual purpose clear,
and provide the additional example of extensions in site-packages.
(cherry picked from commit 242d956)

Co-authored-by: Michał Górny <mgorny@gentoo.org>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@mgorny and @vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit a5936ad into python:3.9 May 28, 2020
@miss-islington miss-islington deleted the backport-242d956-3.9 branch May 28, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.