Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Revert "bpo-32604: [_xxsubinterpreters] Propagate exceptions. (GH-19768)" #20089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Revert "bpo-40613: Remove compiler warning from _xxsubinterpretersmod…
…ule (GH-20069)"

This reverts commit fa0a66e.
  • Loading branch information
vstinner committed May 14, 2020
commit 6e3e31574ba5155d75552cd97e6622f585cd9a30
8 changes: 0 additions & 8 deletions 8 Modules/_xxsubinterpretersmodule.c
Original file line number Diff line number Diff line change
Expand Up @@ -329,15 +329,13 @@ _objsnapshot_clear(_objsnapshot *osn)
// PyMem_Free(osn);
//}

#ifndef NDEBUG
static int
_objsnapshot_is_clear(_objsnapshot *osn)
{
return osn->serialized == NULL
&& _rawstring_is_clear(&osn->modname)
&& _rawstring_is_clear(&osn->clsname);
}
#endif

static void
_objsnapshot_summarize(_objsnapshot *osn, _rawstring *rawbuf, const char *msg)
Expand Down Expand Up @@ -599,15 +597,13 @@ _tbsnapshot_free(_tbsnapshot *tbs)
PyMem_Free(tbs);
}

#ifndef NDEBUG
static int
_tbsnapshot_is_clear(_tbsnapshot *tbs)
{
return tbs->tbs_lineno == -1 && tbs->tbs_next == NULL
&& _rawstring_is_clear(&tbs->tbs_funcname)
&& _rawstring_is_clear(&tbs->tbs_filename);
}
#endif

static int
_tbsnapshot_from_pytb(_tbsnapshot *tbs, PyTracebackObject *pytb)
Expand Down Expand Up @@ -752,7 +748,6 @@ _excsnapshot_free(_excsnapshot *es)
PyMem_Free(es);
}

#ifndef NDEBUG
static int
_excsnapshot_is_clear(_excsnapshot *es)
{
Expand All @@ -763,7 +758,6 @@ _excsnapshot_is_clear(_excsnapshot *es)
&& es->es_msg == NULL
&& _objsnapshot_is_clear(&es->es_object);
}
#endif

static PyObject *
_excsnapshot_get_exc_naive(_excsnapshot *es)
Expand Down Expand Up @@ -1091,15 +1085,13 @@ _sharedexception_free(_sharedexception *she)
PyMem_Free(she);
}

#ifndef NDEBUG
static int
_sharedexception_is_clear(_sharedexception *she)
{
return 1
&& _excsnapshot_is_clear(&she->snapshot)
&& _rawstring_is_clear(&she->msg);
}
#endif

static PyObject *
_sharedexception_get_cause(_sharedexception *sharedexc)
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.