bpo-40585: Normalize errors messages in codeop when comparing them

With the new parser, the error message contains always the trailing newlines, causing the naive comparison of the repr of the error messages in codeop to fail.
python · pablogsal · May 11, 2020 · May 10, 2020 · May 10, 2020 · May 11, 2020
commit de6892a3cc04bdefb2376a912af9685d88432fd9
diff --git a/Lib/codeop.py b/Lib/codeop.py
@@ -93,10 +93,13 @@ def _maybe_compile(compiler, source, filename, symbol):
    except SyntaxError as e:
        err2 = e

+    def normalize_error(err):
+        return repr(err).replace("\\n", "")
+
    try:
        if code:
            return code
-        if not code1 and repr(err1) == repr(err2):
+        if not code1 and normalize_error(err1) == normalize_error(err2):
            raise err1
    finally:
        err1 = err2 = None

diff --git a/Lib/test/test_codeop.py b/Lib/test/test_codeop.py
@@ -288,6 +288,15 @@ def test_invalid(self):

        ai("[i for i in range(10)] = (1, 2, 3)")

+    def test_invalid_exec(self):
+        ai = self.assertInvalid
+        ai("raise = 4", symbol="exec")
+        ai('def a-b', symbol='exec')
+        ai('await?', symbol='exec')
+        ai('=!=', symbol='exec')
+        ai('a await raise b', symbol='exec')
+        ai('a await raise b?+1', symbol='exec')
+
    def test_filename(self):
        self.assertEqual(compile_command("a = 1\n", "abc").co_filename,
                         compile("a = 1\n", "abc", 'single').co_filename)

diff --git a/Misc/NEWS.d/next/Core and Builtins/2020-05-11-00-19-42.bpo-40585.yusknY.rst b/Misc/NEWS.d/next/Core and Builtins/2020-05-11-00-19-42.bpo-40585.yusknY.rst
@@ -0,0 +1,2 @@
+Fixed a bug when using :func:`codeop.compile_command` that was causing
+exceptions to be swallowed with the new parser. Patch by Pablo Galindo
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		Fixed a bug when using :func:`codeop.compile_command` that was causing
		exceptions to be swallowed with the new parser. Patch by Pablo Galindo