bpo-40050: Fix importlib._bootstrap_external

Remove two unused imports: _thread and _weakref. Avoid creating a new winreg builtin module if it's already available in sys.modules. The winreg module is now stored as "winreg" rather than "_winreg".
python · vstinner · Mar 24, 2020 · Mar 24, 2020 · Mar 24, 2020 · 6cc525ec6d5414a979de6f0017aeff5cb29fdc4f
commit 6cc525ec6d5414a979de6f0017aeff5cb29fdc4f
diff --git a/Lib/importlib/_bootstrap_external.py b/Lib/importlib/_bootstrap_external.py
@@ -716,9 +716,9 @@ class WindowsRegistryFinder:
    @classmethod
    def _open_registry(cls, key):
        try:
-            return _winreg.OpenKey(_winreg.HKEY_CURRENT_USER, key)
+            return winreg.OpenKey(winreg.HKEY_CURRENT_USER, key)
        except OSError:
-            return _winreg.OpenKey(_winreg.HKEY_LOCAL_MACHINE, key)
+            return winreg.OpenKey(winreg.HKEY_LOCAL_MACHINE, key)

    @classmethod
    def _search_registry(cls, fullname):
@@ -730,7 +730,7 @@ def _search_registry(cls, fullname):
                                  sys_version='%d.%d' % sys.version_info[:2])
        try:
            with cls._open_registry(key) as hkey:
-                filepath = _winreg.QueryValue(hkey, '')
+                filepath = winreg.QueryValue(hkey, '')
        except OSError:
            return None
        return filepath
@@ -1584,14 +1584,7 @@ def _setup(_bootstrap_module):
    sys = _bootstrap.sys
    _imp = _bootstrap._imp

-    # Directly load built-in modules needed during bootstrap.
    self_module = sys.modules[__name__]
-    for builtin_name in ('_io', '_warnings', 'builtins', 'marshal'):
-        if builtin_name not in sys.modules:
-            builtin_module = _bootstrap._builtin_from_name(builtin_name)
-        else:
-            builtin_module = sys.modules[builtin_name]
-        setattr(self_module, builtin_name, builtin_module)

    # Directly load the os module (needed during bootstrap).
    os_details = ('posix', ['/']), ('nt', ['\\', '/'])
@@ -1610,23 +1603,22 @@ def _setup(_bootstrap_module):
                continue
    else:
        raise ImportError('importlib requires posix or nt')
+
    setattr(self_module, '_os', os_module)
    setattr(self_module, 'path_sep', path_sep)
    setattr(self_module, 'path_separators', ''.join(path_separators))
    setattr(self_module, '_pathseps_with_colon', {f':{s}' for s in path_separators})

-    # Directly load the _thread module (needed during bootstrap).
-    thread_module = _bootstrap._builtin_from_name('_thread')
-    setattr(self_module, '_thread', thread_module)
-
-    # Directly load the _weakref module (needed during bootstrap).
-    weakref_module = _bootstrap._builtin_from_name('_weakref')
-    setattr(self_module, '_weakref', weakref_module)
-
-    # Directly load the winreg module (needed during bootstrap).
+    # Directly load built-in modules needed during bootstrap.
+    builtin_names = ['_io', '_warnings', 'marshal']
    if builtin_os == 'nt':
-        winreg_module = _bootstrap._builtin_from_name('winreg')
-        setattr(self_module, '_winreg', winreg_module)
+        builtin_names.append('winreg')
+    for builtin_name in builtin_names:
+        if builtin_name not in sys.modules:
+            builtin_module = _bootstrap._builtin_from_name(builtin_name)
+        else:
+            builtin_module = sys.modules[builtin_name]
+        setattr(self_module, builtin_name, builtin_module)

    # Constants
    setattr(self_module, '_relax_case', _make_relax_case())

diff --git a/Misc/NEWS.d/next/Library/2020-03-24-16-17-20.bpo-40050.6GrOlz.rst b/Misc/NEWS.d/next/Library/2020-03-24-16-17-20.bpo-40050.6GrOlz.rst
@@ -0,0 +1,3 @@
+Fix ``importlib._bootstrap_external``. Remove two unused imports importlib:
+``_thread`` and ``_weakref``. Avoid creating a new ``winreg`` builtin module if
+it's already available in :data:`sys.modules`.
-Original file line number
+Diff line change
@@ -0,0 +1,3 @@
+    Fix ``importlib._bootstrap_external``. Remove two unused imports importlib:
                   brettcannon marked this conversation as resolved.
              

          
            Show resolved
            Hide resolved
        

                
  
            
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.
+    ``_thread`` and ``_weakref``. Avoid creating a new ``winreg`` builtin module if
+    it's already available in :data:`sys.modules`.