Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-39337: Add a test case for normalizing of codec names #19069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 8, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add codecs_unregister() in testinternalcapi
  • Loading branch information
shihai1991 committed Sep 10, 2020
commit f48e5d9465da9139ae20970b8ded795f4a61ecc3
2 changes: 2 additions & 0 deletions 2 Lib/test/test_codecs.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from test import support
from test.support import os_helper
from test.support import warnings_helper
import _testinternalcapi

try:
import _testcapi
Expand Down Expand Up @@ -3414,6 +3415,7 @@ def search_function(encoding):
codecs.register(search_function)
self.assertEqual((1, 2, 3, 4), codecs.lookup('AAA-8'))
shihai1991 marked this conversation as resolved.
Show resolved Hide resolved
self.assertEqual((None, None, None, None), codecs.lookup('BBB-8'))
_testinternalcapi.codecs_unregister(search_function)


if __name__ == "__main__":
Expand Down
41 changes: 37 additions & 4 deletions 41 Modules/_testinternalcapi.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@
#define PY_SSIZE_T_CLEAN

#include "Python.h"
#include "pycore_bitutils.h" // _Py_bswap32()
#include "pycore_initconfig.h" // _Py_GetConfigsAsDict()
#include "pycore_hashtable.h" // _Py_hashtable_new()
#include "pycore_gc.h" // PyGC_Head
#include "pycore_bitutils.h" // _Py_bswap32()
#include "pycore_initconfig.h" // _Py_GetConfigsAsDict()
#include "pycore_hashtable.h" // _Py_hashtable_new()
#include "pycore_gc.h" // PyGC_Head
#include "internal/pycore_interp.h" // PyInterpreterState_Get()


static PyObject *
Expand All @@ -35,6 +36,37 @@ get_recursion_depth(PyObject *self, PyObject *Py_UNUSED(args))
}


static PyObject*
codecs_unregister(PyObject *self, PyObject *args)
shihai1991 marked this conversation as resolved.
Show resolved Hide resolved
{
PyObject *search_function;

if (!PyArg_ParseTuple(args, "O:codecs_unregister",
&search_function)) {
}
if (search_function == NULL) {
return NULL;
shihai1991 marked this conversation as resolved.
Show resolved Hide resolved
}

PyInterpreterState *interp = PyInterpreterState_Get();
if (interp->codec_search_path == NULL) {
return NULL;
shihai1991 marked this conversation as resolved.
Show resolved Hide resolved
}

Py_ssize_t n = PyList_Size(interp->codec_search_path);
PyObject *list = PyList_New(0);
for (Py_ssize_t i = 0; i < n; i++) {
PyObject *item = PyList_GetItem(interp->codec_search_path, i);
shihai1991 marked this conversation as resolved.
Show resolved Hide resolved
if (item != search_function) {
PyList_Append(list, item);
}
}
Py_SETREF(interp->codec_search_path, list);

Py_RETURN_NONE;
taleinat marked this conversation as resolved.
Show resolved Hide resolved
}


static PyObject*
test_bswap(PyObject *self, PyObject *Py_UNUSED(args))
{
Expand Down Expand Up @@ -234,6 +266,7 @@ test_hashtable(PyObject *self, PyObject *Py_UNUSED(args))
static PyMethodDef TestMethods[] = {
{"get_configs", get_configs, METH_NOARGS},
{"get_recursion_depth", get_recursion_depth, METH_NOARGS},
{"codecs_unregister", codecs_unregister, METH_VARARGS},
{"test_bswap", test_bswap, METH_NOARGS},
{"test_popcount", test_popcount, METH_NOARGS},
{"test_bit_length", test_bit_length, METH_NOARGS},
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.