Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-1294959: Fix typo for new attribute platlibdir.#18960

Merged
miss-islington merged 1 commit intopython:masterpython/cpython:masterfrom
raulcd:fix-type-platlibraulcd/cpython:fix-type-platlibCopy head branch name to clipboard
Mar 12, 2020
Merged

bpo-1294959: Fix typo for new attribute platlibdir.#18960
miss-islington merged 1 commit intopython:masterpython/cpython:masterfrom
raulcd:fix-type-platlibraulcd/cpython:fix-type-platlibCopy head branch name to clipboard

Conversation

@raulcd
Copy link
Contributor

@raulcd raulcd commented Mar 12, 2020

Received email on the docs mailing list to fix a typo from sys.platlitdir which doesn't exist to the correct new attribute sys.platlibdir

https://bugs.python.org/issue1294959

Automerge-Triggered-By: @vstinner

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@raulcd

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Oops, nicely spotted :-)

@miss-islington
Copy link
Contributor

@raulcd: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 3c29675 into python:master Mar 12, 2020
@vstinner
Copy link
Member

Thanks @raulcd :-)

@raulcd
Copy link
Contributor Author

raulcd commented Mar 12, 2020

Thanks @vstinner that was the quickest PR merged on the cpython repo I have seen in all my life :-)

@vstinner
Copy link
Member

Thanks @vstinner that was the quickest PR merged on the cpython repo I have seen in all my life :-)

It's not uncommon. But they are hard to catch since they disappear as soon as they pop up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.