From ae8b457e926f192d743dfc75d41b0ea0545b8385 Mon Sep 17 00:00:00 2001 From: Senthil Kumaran Date: Tue, 31 Dec 2019 13:31:42 -0800 Subject: [PATCH] bpo-27973 - Use test.support.temp_dir instead of NamedTemporaryFile for the desired behavior under windows platform. Suggestion by David Bolen --- Lib/test/test_urllibnet.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Lib/test/test_urllibnet.py b/Lib/test/test_urllibnet.py index df118dc75d1b3f..ef33e3a0ea6173 100644 --- a/Lib/test/test_urllibnet.py +++ b/Lib/test/test_urllibnet.py @@ -1,4 +1,3 @@ -import tempfile import unittest from test import test_support from test.test_urllib2net import skip_ftp_test_on_travis @@ -224,9 +223,10 @@ def test_multiple_ftp_retrieves(self): with test_support.transient_internet(self.FTP_TEST_FILE): try: - for _ in range(self.NUM_FTP_RETRIEVES): - with tempfile.NamedTemporaryFile() as fp: - urllib.FancyURLopener().retrieve(self.FTP_TEST_FILE, fp.name) + for file_num in range(self.NUM_FTP_RETRIEVES): + with test_support.temp_dir() as td: + urllib.FancyURLopener().retrieve(self.FTP_TEST_FILE, + os.path.join(td, str(file_num))) except IOError as e: self.fail("Failed FTP retrieve while accessing ftp url " "multiple times.\n Error message was : %s" % e)