From 5bac32e582a40b2cfcd3f455f58c98dd177be45f Mon Sep 17 00:00:00 2001 From: Zackery Spytz Date: Tue, 23 Jul 2019 22:00:08 -0600 Subject: [PATCH 1/2] bpo-35771: Increase the hover_delay in IDLE's test_tooltip A 50ms delay will often causes failures on slower machines. --- Lib/idlelib/idle_test/test_tooltip.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Lib/idlelib/idle_test/test_tooltip.py b/Lib/idlelib/idle_test/test_tooltip.py index 44ea1110e155dcb..7dad34127bc2c94 100644 --- a/Lib/idlelib/idle_test/test_tooltip.py +++ b/Lib/idlelib/idle_test/test_tooltip.py @@ -102,7 +102,7 @@ def test_showtip_on_mouse_enter_no_delay(self): self.assertGreater(len(tooltip.showtip.call_args_list), 0) def test_showtip_on_mouse_enter_hover_delay(self): - tooltip = Hovertip(self.button, 'ToolTip text', hover_delay=50) + tooltip = Hovertip(self.button, 'ToolTip text', hover_delay=100) self.addCleanup(tooltip.hidetip) tooltip.showtip = add_call_counting(tooltip.showtip) root_update() @@ -128,7 +128,7 @@ def test_hidetip_on_mouse_leave(self): self.assertGreater(len(tooltip.showtip.call_args_list), 0) def test_dont_show_on_mouse_leave_before_delay(self): - tooltip = Hovertip(self.button, 'ToolTip text', hover_delay=50) + tooltip = Hovertip(self.button, 'ToolTip text', hover_delay=100) self.addCleanup(tooltip.hidetip) tooltip.showtip = add_call_counting(tooltip.showtip) root_update() From c249a9f962738d0cac2183bf5a937b7d6e091086 Mon Sep 17 00:00:00 2001 From: Zackery Spytz Date: Sat, 3 Aug 2019 05:28:13 -0600 Subject: [PATCH 2/2] Make the requested changes. --- Lib/idlelib/idle_test/test_tooltip.py | 5 +++-- .../next/IDLE/2019-08-03-05-27-39.bpo-35771.LfQWI-.rst | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) create mode 100644 Misc/NEWS.d/next/IDLE/2019-08-03-05-27-39.bpo-35771.LfQWI-.rst diff --git a/Lib/idlelib/idle_test/test_tooltip.py b/Lib/idlelib/idle_test/test_tooltip.py index 7dad34127bc2c94..2debd3229afa904 100644 --- a/Lib/idlelib/idle_test/test_tooltip.py +++ b/Lib/idlelib/idle_test/test_tooltip.py @@ -102,6 +102,7 @@ def test_showtip_on_mouse_enter_no_delay(self): self.assertGreater(len(tooltip.showtip.call_args_list), 0) def test_showtip_on_mouse_enter_hover_delay(self): + # Fragile test -- see issue 35771. tooltip = Hovertip(self.button, 'ToolTip text', hover_delay=100) self.addCleanup(tooltip.hidetip) tooltip.showtip = add_call_counting(tooltip.showtip) @@ -110,7 +111,7 @@ def test_showtip_on_mouse_enter_hover_delay(self): self.button.event_generate('', x=0, y=0) root_update() self.assertFalse(tooltip.tipwindow and tooltip.tipwindow.winfo_viewable()) - time.sleep(0.1) + time.sleep(0.15) root_update() self.assertTrue(tooltip.tipwindow and tooltip.tipwindow.winfo_viewable()) self.assertGreater(len(tooltip.showtip.call_args_list), 0) @@ -136,7 +137,7 @@ def test_dont_show_on_mouse_leave_before_delay(self): root_update() self.button.event_generate('', x=0, y=0) root_update() - time.sleep(0.1) + time.sleep(0.15) root_update() self.assertFalse(tooltip.tipwindow and tooltip.tipwindow.winfo_viewable()) self.assertEqual(tooltip.showtip.call_args_list, []) diff --git a/Misc/NEWS.d/next/IDLE/2019-08-03-05-27-39.bpo-35771.LfQWI-.rst b/Misc/NEWS.d/next/IDLE/2019-08-03-05-27-39.bpo-35771.LfQWI-.rst new file mode 100644 index 000000000000000..cb3c239e207e253 --- /dev/null +++ b/Misc/NEWS.d/next/IDLE/2019-08-03-05-27-39.bpo-35771.LfQWI-.rst @@ -0,0 +1 @@ +Increase the ``hover_delay`` in IDLE's test_tooltip.