Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.8] bpo-10945: Drop support for bdist_wininst on non-Windows systems (GH-14506)#14510

Merged
miss-islington merged 1 commit intopython:3.8python/cpython:3.8from
miss-islington:backport-72cd653-3.8miss-islington/cpython:backport-72cd653-3.8Copy head branch name to clipboard
Jul 1, 2019
Merged

[3.8] bpo-10945: Drop support for bdist_wininst on non-Windows systems (GH-14506)#14510
miss-islington merged 1 commit intopython:3.8python/cpython:3.8from
miss-islington:backport-72cd653-3.8miss-islington/cpython:backport-72cd653-3.8Copy head branch name to clipboard

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 1, 2019

bdist_wininst depends on MBCS codec, unavailable on non-Windows,
and bdist_wininst have not worked since at least Python 3.2, possibly
never on Python 3.

Here we document that bdist_wininst is only supported on Windows,
and we mark it unsupported otherwise to skip tests.

Distributors of Python 3 can now safely drop the bdist_wininst .exe files
without the need to skip bdist_wininst related tests.
(cherry picked from commit 72cd653)

Co-authored-by: Miro Hrončok miro@hroncok.cz

https://bugs.python.org/issue10945

…honGH-14506)

bdist_wininst depends on MBCS codec, unavailable on non-Windows,
and bdist_wininst have not worked since at least Python 3.2, possibly
never on Python 3.

Here we document that bdist_wininst is only supported on Windows,
and we mark it unsupported otherwise to skip tests.

Distributors of Python 3 can now safely drop the bdist_wininst .exe files
without the need to skip bdist_wininst related tests.
(cherry picked from commit 72cd653)

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@hroncok and @vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit be5bb52 into python:3.8 Jul 1, 2019
@miss-islington miss-islington deleted the backport-72cd653-3.8 branch July 1, 2019 12:54
@miss-islington
Copy link
Contributor Author

@hroncok and @vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.