Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-144851: Fix __lazy_import__ crash with user-defined filters #144852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yhg1s merged 8 commits into from
Mar 2, 2026
Merged

gh-144851: Fix __lazy_import__ crash with user-defined filters #144852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5a7a4f2
Fix `__lazy_import__` crash
johnslavik Feb 15, 2026
c0323cc
Add the crashing test case
johnslavik Feb 27, 2026
a23d40e
Add invariant check
johnslavik Feb 27, 2026
cbcd0b9
Add a test that obviously fails
johnslavik Feb 27, 2026
d2f709d
Revert "Add a test that obviously fails"
johnslavik Feb 27, 2026
7aa1cee
Merge branch 'main' to fix conflicts
johnslavik Feb 28, 2026
e44c378
Merge branch 'main' to fix conflicts (actually this time)
johnslavik Feb 28, 2026
4803e61
Fixup lazy import after merge
johnslavik Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions 5 Lib/test/test_lazy_import/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,11 @@ def test_dunder_lazy_import(self):
import test.test_lazy_import.data.dunder_lazy_import
self.assertNotIn("test.test_lazy_import.data.basic2", sys.modules)

def test_dunder_lazy_import_with_custom_filter(self):
sys.set_lazy_imports_filter(lambda importer, imported, fromlist: False)
import test.test_lazy_import.data.dunder_lazy_import
self.assertIn("test.test_lazy_import.data.basic2", sys.modules)

def test_dunder_lazy_import_used(self):
"""Using __lazy_import__ result should trigger module load."""
import test.test_lazy_import.data.dunder_lazy_import_used
Expand Down
4 changes: 4 additions & 0 deletions 4 Python/import.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4512,6 +4512,10 @@ _PyImport_LazyImportModuleLevelObject(PyThreadState *tstate,
assert(!PyErr_Occurred());
modname = Py_NewRef(Py_None);
}
if (fromlist == NULL) {
assert(!PyErr_Occurred());
fromlist = Py_NewRef(Py_None);
}
PyObject *args[] = {modname, name, fromlist};
PyObject *res = PyObject_Vectorcall(filter, args, 3, NULL);

Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.