gh-120321: Add missing "return false" in gen_try_set_executing#144291
Merged
colesbury merged 1 commit intopython:mainpython/cpython:mainfrom Jan 27, 2026
colesbury:gh-120321-missing-returncolesbury/cpython:gh-120321-missing-returnCopy head branch name to clipboard
Merged
gh-120321: Add missing "return false" in gen_try_set_executing#144291colesbury merged 1 commit intopython:mainpython/cpython:mainfrom colesbury:gh-120321-missing-returncolesbury/cpython:gh-120321-missing-returnCopy head branch name to clipboard
colesbury merged 1 commit intopython:mainpython/cpython:mainfrom
colesbury:gh-120321-missing-returncolesbury/cpython:gh-120321-missing-returnCopy head branch name to clipboard
Conversation
We didn't catch this because of a combination of: 1) falling through to the if-statement below works 2) we only specialized FOR_ITER_GEN for uniquely referenced generators, so we didn't trigger the non-thread-safe behavior.
mpage
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We didn't catch this because of a combination of:
falling through to the if-statement below works
we only specialized FOR_ITER_GEN for uniquely referenced generators,
so we didn't trigger the non-thread-safe behavior.