Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[2.7] bpo-37124: Fix reference leak in test_msilib (GH-13750)#14340

Merged
vstinner merged 1 commit intopython:2.7python/cpython:2.7from
vstinner:test_msilib27Copy head branch name to clipboard
Jun 24, 2019
Merged

[2.7] bpo-37124: Fix reference leak in test_msilib (GH-13750)#14340
vstinner merged 1 commit intopython:2.7python/cpython:2.7from
vstinner:test_msilib27Copy head branch name to clipboard

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jun 24, 2019

(cherry picked from commit c0295db)

https://bugs.python.org/issue37124

@vstinner
Copy link
Member Author

Compared to the change in master, I also added:

        self.addCleanup(unlink, db_path)
        self.addCleanup(db.Close)

@vstinner
Copy link
Member Author

self.addCleanup(db.Close) doesn't work: AttributeError: '_msi.Database' object has no attribute 'Close'.

I removed:

        self.addCleanup(unlink, db_path)
        self.addCleanup(db.Close)

@vstinner vstinner merged commit 6cbff56 into python:2.7 Jun 24, 2019
@vstinner vstinner deleted the test_msilib27 branch June 24, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.