gh-120321: Avoid -Wunreachable-code warning on Clang#143022
Merged
colesbury merged 1 commit intopython:mainpython/cpython:mainfrom Dec 20, 2025
colesbury:gh-120321-unused-codecolesbury/cpython:gh-120321-unused-codeCopy head branch name to clipboard
Merged
gh-120321: Avoid -Wunreachable-code warning on Clang#143022colesbury merged 1 commit intopython:mainpython/cpython:mainfrom colesbury:gh-120321-unused-codecolesbury/cpython:gh-120321-unused-codeCopy head branch name to clipboard
-Wunreachable-code warning on Clang#143022colesbury merged 1 commit intopython:mainpython/cpython:mainfrom
colesbury:gh-120321-unused-codecolesbury/cpython:gh-120321-unused-codeCopy head branch name to clipboard
Conversation
Contributor
Author
|
I hate this, but I hate the other options even more. |
mpage
approved these changes
Dec 20, 2025
Contributor
mpage
left a comment
There was a problem hiding this comment.
We'll end up seeing the warning if clang's analysis gets more capable, right? I guess that's still better than disabling warnings around the block in the default build.
Test failure looks unrelated.
Contributor
Author
I think it's more a matter of convention than capability. Clang can easily optimize through all these things and this warning is only enabled in optimized builds (not debug builds). Clang doesn't warn for things like: But it warns for: But not for: But you can't put that expression in a macro: |
cocolato
pushed a commit
to cocolato/cpython
that referenced
this pull request
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.