[3.14] GH-139653: Only raise an exception (or fatal error) when the stack pointer is about to overflow the stack. (GH-141711)#141944
Merged
encukou merged 1 commit intopython:3.14python/cpython:3.14from Nov 26, 2025
encukou:backport-c25a070-3.14encukou/cpython:backport-c25a070-3.14Copy head branch name to clipboard
Merged
[3.14] GH-139653: Only raise an exception (or fatal error) when the stack pointer is about to overflow the stack. (GH-141711)#141944encukou merged 1 commit intopython:3.14python/cpython:3.14from encukou:backport-c25a070-3.14encukou/cpython:backport-c25a070-3.14Copy head branch name to clipboard
encukou merged 1 commit intopython:3.14python/cpython:3.14from
encukou:backport-c25a070-3.14encukou/cpython:backport-c25a070-3.14Copy head branch name to clipboard
Conversation
… the stack pointer is about to overflow the stack. (pythonGH-141711) Only raises if the stack pointer is both below the limit *and* above the stack base. This prevents false positives for user-space threads, as the stack pointer will be outside those bounds if the stack has been swapped. Cherry-picked from commit c25a070
vstinner
approved these changes
Nov 25, 2025
Member
vstinner
left a comment
There was a problem hiding this comment.
LGTM. Good idea to backport the whole internal documentation.
Contributor
|
Backporting this (together with #141661) makes KiCad work for me on Fedora 43. |
markshannon
approved these changes
Nov 25, 2025
Member
markshannon
left a comment
There was a problem hiding this comment.
Thanks for doing this. Adding the docs is a good idea.
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 0728b62 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F141944%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only raises if the stack pointer is both below the limit and above the stack base. This prevents false positives for user-space threads, as the stack pointer will be outside those bounds if the stack has been swapped.
Cherry-picked from commit c25a070
I'm also including the whole page of internal documentation, rather than ignore the conflict there.