gh-130317: Fix SNaN broken tests on HP PA RISC#140452
Merged
vstinner merged 3 commits intopython:mainpython/cpython:mainfrom Oct 22, 2025
Merged
gh-130317: Fix SNaN broken tests on HP PA RISC#140452vstinner merged 3 commits intopython:mainpython/cpython:mainfrom
vstinner merged 3 commits intopython:mainpython/cpython:mainfrom
Conversation
While looking at python#140028 I found some unrelated test regressions in the 3.14 cycle. These seem to all come from python#130317. From what I can tell, that made Python more correct than it was before. According to [0] HP PA RISC uses 1 for SNaN and thus a 0 for QNaN. Update tests to expect this. [0]: https://grouper.ieee.org/groups/1788/email/msg03272.html
Contributor
Author
|
FYI: @thesamesam |
skirpichev
reviewed
Oct 22, 2025
skirpichev
reviewed
Oct 22, 2025
Member
|
CC @vstinner |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 22, 2025
While looking at pythonGH-140028, I found some unrelated test regressions in the 3.14 cycle. These seem to all come from pythonGH-130317. From what I can tell, that made Python more correct than it was before. According to [0], HP PA RISC uses 1 for SNaN and thus a 0 for QNaN. [0]: https://grouper.ieee.org/groups/1788/email/msg03272.html (cherry picked from commit 76fea55) Co-authored-by: Stefano Rivera <stefano@rivera.za.net>
|
GH-140467 is a backport of this pull request to the 3.14 branch. |
Member
|
Merged, thanks. |
vstinner
pushed a commit
that referenced
this pull request
Oct 22, 2025
…40467) gh-130317: Fix SNaN broken tests on HP PA RISC (GH-140452) While looking at GH-140028, I found some unrelated test regressions in the 3.14 cycle. These seem to all come from GH-130317. From what I can tell, that made Python more correct than it was before. According to [0], HP PA RISC uses 1 for SNaN and thus a 0 for QNaN. [0]: https://grouper.ieee.org/groups/1788/email/msg03272.html (cherry picked from commit 76fea55) Co-authored-by: Stefano Rivera <stefano@rivera.za.net>
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
While looking at python#140028, I found some unrelated test regressions in the 3.14 cycle. These seem to all come from python#130317. From what I can tell, that made Python more correct than it was before. According to [0], HP PA RISC uses 1 for SNaN and thus a 0 for QNaN. [0]: https://grouper.ieee.org/groups/1788/email/msg03272.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at #140028 I found some unrelated test regressions in the 3.14 cycle. These seem to all come from #130317. From what I can tell, that made Python more correct than it was before. According to 0 HP PA RISC uses 1 for SNaN and thus a 0 for QNaN.
Update tests to expect this.
nanfloats is non-invertible #130317