Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.8] bpo-26219: Fix compiler warning in _PyCode_InitOpcache() (GH-13997)#14000

Merged
vstinner merged 1 commit intopython:3.8python/cpython:3.8from
miss-islington:backport-376ce98-3.8miss-islington/cpython:backport-376ce98-3.8Copy head branch name to clipboard
Jun 12, 2019
Merged

[3.8] bpo-26219: Fix compiler warning in _PyCode_InitOpcache() (GH-13997)#14000
vstinner merged 1 commit intopython:3.8python/cpython:3.8from
miss-islington:backport-376ce98-3.8miss-islington/cpython:backport-376ce98-3.8Copy head branch name to clipboard

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 12, 2019

Fix MSVC warning:

objects\codeobject.c(285): warning C4244: '=':
conversion from 'Py_ssize_t' to 'unsigned char',
possible loss of data

(cherry picked from commit 376ce98)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue26219

)

Fix MSVC warning:

    objects\codeobject.c(285): warning C4244: '=':
    conversion from 'Py_ssize_t' to 'unsigned char',
    possible loss of data
(cherry picked from commit 376ce98)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a failure ❌ .

@vstinner vstinner merged commit 996e526 into python:3.8 Jun 12, 2019
@miss-islington miss-islington deleted the backport-376ce98-3.8 branch June 12, 2019 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.