-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
Fix typo in Lib/concurrent/futures/thread.py #13953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar wording in ProcessPoolExecutor
docstring :
cpython/Lib/concurrent/futures/process.py
Line 508 in 408a2ef
initializer: An callable used to initialize worker processes. |
I added the correction to a new commit. Edit: I registered on BPO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I would prefer a review from a native English speaker too. Fixing typos don't require CLA signing but I will leave it to core dev merging this. Thanks for the PR.
Thanks @ubordignon for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
(cherry picked from commit 552ace7) Co-authored-by: ubordignon <48903745+ubordignon@users.noreply.github.com>
GH-14107 is a backport of this pull request to the 3.8 branch. |
(cherry picked from commit 552ace7) Co-authored-by: ubordignon <48903745+ubordignon@users.noreply.github.com>
GH-14108 is a backport of this pull request to the 3.7 branch. |
@ubordignon, welcome to CPython and thank you for your contribution. 🎉 |
(cherry picked from commit 552ace7) Co-authored-by: ubordignon <48903745+ubordignon@users.noreply.github.com>
Thanks a lot! |
(cherry picked from commit 552ace7) Co-authored-by: ubordignon <48903745+ubordignon@users.noreply.github.com>
Changed "an" to "a".