Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix typo in Lib/concurrent/futures/thread.py #13953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2019

Conversation

ubordignon
Copy link
Contributor

Changed "an" to "a".

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar wording in ProcessPoolExecutor docstring :

initializer: An callable used to initialize worker processes.

@ubordignon
Copy link
Contributor Author

ubordignon commented Jun 11, 2019

cpython/Lib/concurrent/futures/process.py

I added the correction to a new commit.
I signed the CLA referencing my GitHub account. Should I also register on bpo? I hear you're moving over to GitHub.

Edit: I registered on BPO

Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would prefer a review from a native English speaker too. Fixing typos don't require CLA signing but I will leave it to core dev merging this. Thanks for the PR.

@miss-islington
Copy link
Contributor

Thanks @ubordignon for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 15, 2019
(cherry picked from commit 552ace7)

Co-authored-by: ubordignon <48903745+ubordignon@users.noreply.github.com>
@bedevere-bot
Copy link

GH-14107 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 15, 2019
(cherry picked from commit 552ace7)

Co-authored-by: ubordignon <48903745+ubordignon@users.noreply.github.com>
@bedevere-bot
Copy link

GH-14108 is a backport of this pull request to the 3.7 branch.

@csabella
Copy link
Contributor

@ubordignon, welcome to CPython and thank you for your contribution. 🎉

miss-islington added a commit that referenced this pull request Jun 15, 2019
(cherry picked from commit 552ace7)

Co-authored-by: ubordignon <48903745+ubordignon@users.noreply.github.com>
@ubordignon
Copy link
Contributor Author

Thanks a lot!

miss-islington added a commit that referenced this pull request Jun 15, 2019
(cherry picked from commit 552ace7)

Co-authored-by: ubordignon <48903745+ubordignon@users.noreply.github.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.