[3.14] gh-136264: Fix --relative-paths for PEP 739's build-details.json (GH-138510)#138638
Merged
hugovk merged 4 commits intopython:3.14python/cpython:3.14from Sep 9, 2025
miss-islington:backport-057ee17-3.14miss-islington/cpython:backport-057ee17-3.14Copy head branch name to clipboard
Merged
[3.14] gh-136264: Fix --relative-paths for PEP 739's build-details.json (GH-138510)#138638hugovk merged 4 commits intopython:3.14python/cpython:3.14from miss-islington:backport-057ee17-3.14miss-islington/cpython:backport-057ee17-3.14Copy head branch name to clipboard
--relative-paths for PEP 739's build-details.json (GH-138510)#138638hugovk merged 4 commits intopython:3.14python/cpython:3.14from
miss-islington:backport-057ee17-3.14miss-islington/cpython:backport-057ee17-3.14Copy head branch name to clipboard
Conversation
….json (pythonGH-138510) * KeyError is not raised for defaultdict * Fix relative paths on different drives on Windows * Add a round-trip test (cherry picked from commit 057ee17) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Itamar Oren <itamarost@gmail.com>
AA-Turner
approved these changes
Sep 8, 2025
hugovk
previously requested changes
Sep 8, 2025
Member
hugovk
left a comment
There was a problem hiding this comment.
Erm, let's have a passing CI before merge :)
test test_build_details crashed -- Traceback (most recent call last):
File "/home/runner/work/cpython/cpython/Lib/test/libregrtest/single.py", line 210, in _runtest_env_changed_exc
_load_run_test(result, runtests)
~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
File "/home/runner/work/cpython/cpython/Lib/test/libregrtest/single.py", line 155, in _load_run_test
test_mod = importlib.import_module(module_name)
File "/home/runner/work/cpython/cpython/Lib/importlib/__init__.py", line 88, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "<frozen importlib._bootstrap>", line 1398, in _gcd_import
File "<frozen importlib._bootstrap>", line 1371, in _find_and_load
File "<frozen importlib._bootstrap>", line 1342, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 938, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 762, in exec_module
File "<frozen importlib._bootstrap>", line 491, in _call_with_frames_removed
File "/home/runner/work/cpython/cpython/Lib/test/test_build_details.py", line 182, in <module>
@unittest.skipIf(is_wasm32, 'Feature not available on WebAssembly builds')
^^^^^^^^^
NameError: name 'is_wasm32' is not defined. Did you mean: 'is_wasi'?|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
AA-Turner
reviewed
Sep 8, 2025
Member
Member
|
Tests now passing |
hugovk
reviewed
Sep 8, 2025
Member
|
I didn't expect the Spanish Inquisition! A |
Member
|
Oh boo the fun trigger hasn't worked. I have made the requested changes; please review again |
itamaro
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 057ee17)
Co-authored-by: Adam Turner 9087854+AA-Turner@users.noreply.github.com
Co-authored-by: Itamar Oren itamarost@gmail.com