gh-136021: Remove dead code for internal sentinel in typing#138120
Merged
AlexWaygood merged 1 commit intopython:mainpython/cpython:mainfrom Aug 24, 2025
brianschubert:typing-dead-sentinelbrianschubert/cpython:typing-dead-sentinelCopy head branch name to clipboard
Merged
gh-136021: Remove dead code for internal sentinel in typing#138120AlexWaygood merged 1 commit intopython:mainpython/cpython:mainfrom brianschubert:typing-dead-sentinelbrianschubert/cpython:typing-dead-sentinelCopy head branch name to clipboard
typing#138120AlexWaygood merged 1 commit intopython:mainpython/cpython:mainfrom
brianschubert:typing-dead-sentinelbrianschubert/cpython:typing-dead-sentinelCopy head branch name to clipboard
Conversation
JelleZijlstra
approved these changes
Aug 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last use of this sentinel was removed in #136332
I think this is
skip-news, since there's no user facing change in behavior and the global instance (typing._sentinel) was already unceremoniously removed without a news mention.type_paramsin_eval_typeand_evaluate#136021