gh-137084: Do not call get_gc_state from inside loop in expand_region_transitivly_reachable#137085
Merged
kumaraditya303 merged 1 commit intopython:mainpython/cpython:mainfrom Jul 25, 2025
sergey-miryanov:avoid-calling-get_gc_state-inside-loopsergey-miryanov/cpython:avoid-calling-get_gc_state-inside-loopCopy head branch name to clipboard
Merged
gh-137084: Do not call get_gc_state from inside loop in expand_region_transitivly_reachable#137085kumaraditya303 merged 1 commit intopython:mainpython/cpython:mainfrom sergey-miryanov:avoid-calling-get_gc_state-inside-loopsergey-miryanov/cpython:avoid-calling-get_gc_state-inside-loopCopy head branch name to clipboard
kumaraditya303 merged 1 commit intopython:mainpython/cpython:mainfrom
sergey-miryanov:avoid-calling-get_gc_state-inside-loopsergey-miryanov/cpython:avoid-calling-get_gc_state-inside-loopCopy head branch name to clipboard
Conversation
Contributor
Author
|
I believe this should skip news. |
Contributor
|
cc @markshannon as original author |
kumaraditya303
approved these changes
Jul 25, 2025
Contributor
Author
|
Thanks everyone! |
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is minor refactoring. But I believe it is worth to do in the light of increasing usage of Immortal objects.
get_gc_state is not so lightweight and may have extra costs when calling for large number of immortal objects.